Ticket #13 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Editing a PC inserts incorrect spaces into argument

Reported by: andreas.faerber@… Owned by: mike
Priority: normal Milestone: Q-0.9.1aX
Component: editPC Version: Q-0.9.0a89
Severity: minor Keywords:
Cc:

Description

Q relies on the guest command line arguments in the configuration file being separated by single whitespace characters.

This is problematic because editing a PC without manual QEMU parameters adds a whitespace character before such an empty string, leading to a constantly growing file and inability to launch the guest.

An initial patch was provided to start tackling this.

But additionally, Q does not recognize every single-token parameter and tracking those is a tedious task. Instead, once initial fixes are in place, the argument parsing should be revisited to no longer rely on this string-explosion based on whitespace character, i.e. tokenizing quoted and unquoted strings, ignoring any combination of whitespace characters in between.

Attachments

editpc_space.diff Download (0.6 KB) - added by andreasf 3 years ago.
Patch to only append non-empty QEMU parameters

Change History

Changed 3 years ago by andreasf

Patch to only append non-empty QEMU parameters

Changed 3 years ago by cordney

  • status changed from new to closed
  • resolution set to fixed

fixed (r90), single-token parameter problem moved to #30

Changed 3 years ago by mike

  • milestone changed from Q-0.9.0aX to Q-0.9.1aX
Note: See TracTickets for help on using tickets.